Messages in this thread | | | Date | Tue, 11 Feb 2020 17:39:24 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v5 01/18] platform/x86: intel_scu_ipc: Split out SCU IPC functionality from the SCU driver |
| |
On Tue, Feb 11, 2020 at 04:25:46PM +0300, Mika Westerberg wrote: > The SCU IPC functionality is usable outside of Intel MID devices. For > example modern Intel CPUs include the same thing but now it is called > PMC (Power Management Controller) instead of SCU. To make the IPC > available for those split the driver into core part (intel_scu_ipc.c) > and the SCU PCI driver part (intel_scu_pcidrv.c) which then calls the > former before it goes and creates rest of the SCU devices. The SCU IPC > will also register a new class that gets assigned to the device that is > created under the parent PCI device. > > We also split the Kconfig symbols so that INTEL_SCU_IPC enables the SCU > IPC library and INTEL_SCU_PCI the SCU driver and convert the users > accordingly. While there remove default y from the INTEL_SCU_PCI symbol > as it is already selected by X86_INTEL_MID.
...
> config INTEL_SCU_IPC
> +config INTEL_SCU
> +config INTEL_SCU_PCI
> config INTEL_SCU_IPC_UTIL ...
> obj-$(CONFIG_INTEL_PUNIT_IPC) += intel_punit_ipc.o > obj-$(CONFIG_INTEL_SCU_IPC) += intel_scu_ipc.o > obj-$(CONFIG_INTEL_SCU_IPC_UTIL) += intel_scu_ipcutil.o > +obj-$(CONFIG_INTEL_SCU_PCI) += intel_scu_pcidrv.o
Please, keep the symbol ordering (whatever you choose) the same in Makefile and Kconfig.
-- With Best Regards, Andy Shevchenko
| |