Messages in this thread | | | Subject | Re: [PATCH v3 1/3] printk: Move console matching logic into a separate function | From | Benjamin Herrenschmidt <> | Date | Tue, 11 Feb 2020 16:26:42 +0100 |
| |
On Tue, 2020-02-11 at 15:29 +0100, Petr Mladek wrote: > > @@ -2626,6 +2627,60 @@ static int __init keep_bootcon_setup(char *str) > > + /* > > + * Some consoles, such as pstore and netconsole, can be enabled even > > + * without matching. > > + */ > > There are few lines in the patchset where the indentation is done > by spaces instead of tabs. The above 3 lines are just one example.
Odd. Something must have gone wrong with my emacs config when I switched laptops, I'll have a look thanks.
> I'll fix this when pushing. But please, be more careful next time ;-) > I suggest to use some more clever editor that helps with code > formatting.
I normally do :)
> Also I suggest to run ./scripts/checkpatch.pl on the patches > before sending.
Yeah I never quite got that knack, I still keep forgetting ... the doom of old habits, I didn't even when I was maintainer of arch/powerpc ... oops :)
But yeah, I'll try to remember next time.
> Also the three patches were not send in a single thread so that > it was harder to find all the pieces. I personally use: > > git format-patch --cover-letter origin/master -o some-dir > ./scripts/checkpatch.pl some-dir/* > $> edit some-dir/0000-*.patch > git send-email --smtp-server=... --to= --cc= ... some-dir/*
I usually do when it's more than a couple of patches but yeah, again, bad old habits. Sorry about that.
Cheers, Ben.
| |