lkml.org 
[lkml]   [2020]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] tracing: Don't return -EINVAL when tracing soft disabled synth events
On Wed, 12 Feb 2020 12:24:15 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:

> On Mon, 10 Feb 2020 17:06:49 -0600
> Tom Zanussi <zanussi@kernel.org> wrote:
>
> > There's no reason to return -EINVAL when tracing a synthetic event if
> > it's soft disabled - treat it the same as if it were hard disabled and
> > return normally.
> >
> > Have synth_event_trace() and synth_event_trace_array() just return
> > normally, and have synth_event_trace_start set the trace state to
> > disabled and return.
> >
>
> Looks good to me.
>
> Reviewed-by: Masami Hiramatsu <mhiramat@kernel.org>
>

Thanks for the review Masami, but these patches have already landed in
Linus's tree ;-)

-- Steve

\
 
 \ /
  Last update: 2020-02-12 04:29    [W:0.093 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site