Messages in this thread | | | Date | Tue, 11 Feb 2020 23:25:06 +0100 | From | Andrew Lunn <> | Subject | Re: [PATCH 03/14] net: davicom: dm9000: allow to pass MAC address through mac_addr module parameter |
| |
On Tue, Feb 11, 2020 at 10:41:20PM +0100, H. Nikolaus Schaller wrote: > This is needed to give the MIPS Ingenic CI20 board a stable MAC address > which can be optionally provided by vendor U-Boot. > > For get_mac_addr() we use an adapted copy of from ksz884x.c which > has very similar functionality. > > Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
Hi Nikolaus
Please split these patches by subsystem. So this one patch needs to go via netdev.
> +static char *mac_addr = ":"; > +module_param(mac_addr, charp, 0); > +MODULE_PARM_DESC(mac_addr, "MAC address");
Module parameters are not liked.
Can it be passed via device tree? The driver already has code to get it out of the device tree.
Andrew
| |