lkml.org 
[lkml]   [2020]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 093/309] ubifs: Fix wrong memory allocation
    Date
    From: Sascha Hauer <s.hauer@pengutronix.de>

    commit edec51374bce779f37fc209a228139c55d90ec8d upstream.

    In create_default_filesystem() when we allocate the idx node we must use
    the idx_node_size we calculated just one line before, not tmp, which
    contains completely other data.

    Fixes: c4de6d7e4319 ("ubifs: Refactor create_default_filesystem()")
    Cc: stable@vger.kernel.org # v4.20+
    Reported-by: Naga Sureshkumar Relli <nagasure@xilinx.com>
    Tested-by: Naga Sureshkumar Relli <nagasure@xilinx.com>
    Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
    Signed-off-by: Richard Weinberger <richard@nod.at>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/ubifs/sb.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/fs/ubifs/sb.c
    +++ b/fs/ubifs/sb.c
    @@ -161,7 +161,7 @@ static int create_default_filesystem(str
    sup = kzalloc(ALIGN(UBIFS_SB_NODE_SZ, c->min_io_size), GFP_KERNEL);
    mst = kzalloc(c->mst_node_alsz, GFP_KERNEL);
    idx_node_size = ubifs_idx_node_sz(c, 1);
    - idx = kzalloc(ALIGN(tmp, c->min_io_size), GFP_KERNEL);
    + idx = kzalloc(ALIGN(idx_node_size, c->min_io_size), GFP_KERNEL);
    ino = kzalloc(ALIGN(UBIFS_INO_NODE_SZ, c->min_io_size), GFP_KERNEL);
    cs = kzalloc(ALIGN(UBIFS_CS_NODE_SZ, c->min_io_size), GFP_KERNEL);


    \
     
     \ /
      Last update: 2020-02-10 14:21    [W:2.195 / U:0.800 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site