lkml.org 
[lkml]   [2020]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.5 064/367] lib/test_kasan.c: fix memory leak in kmalloc_oob_krealloc_more()
    Date
    From: Gustavo A. R. Silva <gustavo@embeddedor.com>

    commit 3e21d9a501bf99aee2e5835d7f34d8c823f115b5 upstream.

    In case memory resources for _ptr2_ were allocated, release them before
    return.

    Notice that in case _ptr1_ happens to be NULL, krealloc() behaves
    exactly like kmalloc().

    Addresses-Coverity-ID: 1490594 ("Resource leak")
    Link: http://lkml.kernel.org/r/20200123160115.GA4202@embeddedor
    Fixes: 3f15801cdc23 ("lib: add kasan test module")
    Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
    Reviewed-by: Dmitry Vyukov <dvyukov@google.com>
    Cc: <stable@vger.kernel.org>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    lib/test_kasan.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/lib/test_kasan.c
    +++ b/lib/test_kasan.c
    @@ -158,6 +158,7 @@ static noinline void __init kmalloc_oob_
    if (!ptr1 || !ptr2) {
    pr_err("Allocation failed\n");
    kfree(ptr1);
    + kfree(ptr2);
    return;
    }


    \
     
     \ /
      Last update: 2020-02-10 13:44    [W:4.611 / U:0.132 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site