lkml.org 
[lkml]   [2020]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 09/11] kasan: add missing annotation for start_report()
    On Sun, Feb 9, 2020 at 11:48 PM Jules Irenge <jbi.octave@gmail.com> wrote:
    >
    > Sparse reports a warning at start_report()
    >
    > warning: context imbalance in start_report() - wrong count at exit
    >
    > The root cause is a missing annotation at start_report()
    >
    > Add the missing annotation __acquires(&report_lock)
    >
    > Signed-off-by: Jules Irenge <jbi.octave@gmail.com>

    Acked-by: Dmitry Vyukov <dvyukov@google.com>

    > ---
    > mm/kasan/report.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/mm/kasan/report.c b/mm/kasan/report.c
    > index 5ef9f24f566b..5451624c4e09 100644
    > --- a/mm/kasan/report.c
    > +++ b/mm/kasan/report.c
    > @@ -77,7 +77,7 @@ static void print_error_description(struct kasan_access_info *info)
    >
    > static DEFINE_SPINLOCK(report_lock);
    >
    > -static void start_report(unsigned long *flags)
    > +static void start_report(unsigned long *flags) __acquires(&report_lock)
    > {
    > /*
    > * Make sure we don't end up in loop.
    > --
    > 2.24.1
    >

    \
     
     \ /
      Last update: 2020-02-10 08:29    [W:3.162 / U:0.188 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site