lkml.org 
[lkml]   [2020]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 243/309] phy: qualcomm: Adjust indentation in read_poll_timeout
    Date
    From: Nathan Chancellor <natechancellor@gmail.com>

    commit a89806c998ee123bb9c0f18526e55afd12c0c0ab upstream.

    Clang warns:

    ../drivers/phy/qualcomm/phy-qcom-apq8064-sata.c:83:4: warning:
    misleading indentation; statement is not part of the previous 'if'
    [-Wmisleading-indentation]
    usleep_range(DELAY_INTERVAL_US, DELAY_INTERVAL_US + 50);
    ^
    ../drivers/phy/qualcomm/phy-qcom-apq8064-sata.c:80:3: note: previous
    statement is here
    if (readl_relaxed(addr) & mask)
    ^
    1 warning generated.

    This warning occurs because there is a space after the tab on this line.
    Remove it so that the indentation is consistent with the Linux kernel
    coding style and clang no longer warns.

    Fixes: 1de990d8a169 ("phy: qcom: Add driver for QCOM APQ8064 SATA PHY")
    Link: https://github.com/ClangBuiltLinux/linux/issues/816
    Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
    Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
    Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/phy/qualcomm/phy-qcom-apq8064-sata.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/phy/qualcomm/phy-qcom-apq8064-sata.c
    +++ b/drivers/phy/qualcomm/phy-qcom-apq8064-sata.c
    @@ -80,7 +80,7 @@ static int read_poll_timeout(void __iome
    if (readl_relaxed(addr) & mask)
    return 0;

    - usleep_range(DELAY_INTERVAL_US, DELAY_INTERVAL_US + 50);
    + usleep_range(DELAY_INTERVAL_US, DELAY_INTERVAL_US + 50);
    } while (!time_after(jiffies, timeout));

    return (readl_relaxed(addr) & mask) ? 0 : -ETIMEDOUT;

    \
     
     \ /
      Last update: 2020-02-10 13:42    [W:4.181 / U:0.240 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site