lkml.org 
[lkml]   [2020]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 221/309] KVM: x86: Free wbinvd_dirty_mask if vCPU creation fails
    Date
    From: Sean Christopherson <sean.j.christopherson@intel.com>

    commit 16be9ddea268ad841457a59109963fff8c9de38d upstream.

    Free the vCPU's wbinvd_dirty_mask if vCPU creation fails after
    kvm_arch_vcpu_init(), e.g. when installing the vCPU's file descriptor.
    Do the freeing by calling kvm_arch_vcpu_free() instead of open coding
    the freeing. This adds a likely superfluous, but ultimately harmless,
    call to kvmclock_reset(), which only clears vcpu->arch.pv_time_enabled.
    Using kvm_arch_vcpu_free() allows for additional cleanup in the future.

    Fixes: f5f48ee15c2ee ("KVM: VMX: Execute WBINVD to keep data consistency with assigned devices")
    Cc: stable@vger.kernel.org
    Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
    Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    arch/x86/kvm/x86.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/arch/x86/kvm/x86.c
    +++ b/arch/x86/kvm/x86.c
    @@ -9180,7 +9180,7 @@ void kvm_arch_vcpu_destroy(struct kvm_vc
    kvm_mmu_unload(vcpu);
    vcpu_put(vcpu);

    - kvm_x86_ops->vcpu_free(vcpu);
    + kvm_arch_vcpu_free(vcpu);
    }

    void kvm_vcpu_reset(struct kvm_vcpu *vcpu, bool init_event)

    \
     
     \ /
      Last update: 2020-02-10 13:42    [W:2.516 / U:0.504 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site