lkml.org 
[lkml]   [2020]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] tools/bootconfig: Fix wrong __VA_ARGS__ usage
Date
Masami Hiramatsu <mhiramat@kernel.org> writes:
> Since printk() wrapper macro uses __VA_ARGS__ without
> "##" prefix, it causes a build error if there is no
> variable arguments (e.g. only fmt is specified.)
> To fix this error, use ##__VA_ARGS__ instead of
> __VAR_ARGS__.
>
> Fixes: 950313ebf79c ("tools: bootconfig: Add bootconfig command")
> Reported-by: Michael Ellerman <mpe@ellerman.id.au>
> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> ---
> tools/bootconfig/include/linux/printk.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/bootconfig/include/linux/printk.h b/tools/bootconfig/include/linux/printk.h
> index 017bcd6912a5..e978a63d3222 100644
> --- a/tools/bootconfig/include/linux/printk.h
> +++ b/tools/bootconfig/include/linux/printk.h
> @@ -7,7 +7,7 @@
> /* controllable printf */
> extern int pr_output;
> #define printk(fmt, ...) \
> - (pr_output ? printf(fmt, __VA_ARGS__) : 0)
> + (pr_output ? printf(fmt, ##__VA_ARGS__) : 0)
>
> #define pr_err printk
> #define pr_warn printk

Tested-by: Michael Ellerman <mpe@ellerman.id.au>

cheers

\
 
 \ /
  Last update: 2020-02-10 10:51    [W:0.156 / U:3.568 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site