Messages in this thread | | | Date | Mon, 10 Feb 2020 10:41:51 +0100 | From | Maxime Ripard <> | Subject | Re: [PATCH] ARM: dts: sun5i: Add dts for inet86v_rev2 |
| |
Hi,
On Mon, Feb 10, 2020 at 10:27:36AM +0100, agriveaux@deutnet.info wrote: > From: Alexandre GRIVEAUX <agriveaux@deutnet.info> > > Add Inet 86V Rev 2 support, based upon Inet 86VS. > > Missing things: > - Accelerometer (MXC6225X) > - Touchpanel (Sitronix SL1536) > - Nand (29F32G08CBACA) > - Camera (HCWY0308)
Same thing than for U-Boot, you're missing your SoB.
> --- > arch/arm/boot/dts/sun5i-a13-inet-86v-rev2.dts | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > create mode 100644 arch/arm/boot/dts/sun5i-a13-inet-86v-rev2.dts > > diff --git a/arch/arm/boot/dts/sun5i-a13-inet-86v-rev2.dts b/arch/arm/boot/dts/sun5i-a13-inet-86v-rev2.dts > new file mode 100644 > index 000000000000..e73abb9a1e32 > --- /dev/null > +++ b/arch/arm/boot/dts/sun5i-a13-inet-86v-rev2.dts > @@ -0,0 +1,17 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * Copyright 2020 Alexandre Griveaux <agriveaux@deutnet.info> > + * > + * Minimal dts file for the iNet 86V > + */ > + > +/dts-v1/; > + > +#include "sun5i-a13.dtsi" > +#include "sun5i-reference-design-tablet.dtsi" > + > +/ { > + model = "iNET 86V Rev 02"; > + compatible = "inet,86v-rev2", "allwinner,sun5i-a13"; > + > +};
If it's exactly the same device, why do we need another device tree?
Maxime [unhandled content-type:application/pgp-signature] | |