lkml.org 
[lkml]   [2020]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ASoC: dmaengine_pcm: Consider DMA cache caused delay in pointer callback
On Mon, Feb 10, 2020 at 04:28:44PM +0200, Peter Ujfalusi wrote:
> On 10/02/2020 16.21, Takashi Iwai wrote:

> >> delay += codec_delay;
> >>
> >> - runtime->delay = delay;
> >> + runtime->delay += delay;

> > Is it correct?
> > delay already takes runtime->delay as its basis, so it'll result in a
> > double.

> The delay here is coming from the DAI and the codec.
> The runtime->delay hold the PCM (DMA) caused delay.

I think Takashi's point here (and a query I have) is that we end up with

delay = runtime->delay;
delay += stuff;
runtime->delay += delay;

which is equivalent to

runtime->delay = (runtime->delay * 2) + stuff;

and that's a bit surprising.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2020-02-10 15:39    [W:0.047 / U:1.476 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site