lkml.org 
[lkml]   [2020]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] iov_iter: optimise bvec iov_iter_advance()
    From
    Date
    On 09/12/2020 08:33, Christoph Hellwig wrote:
    > On Thu, Dec 03, 2020 at 11:48:56AM +0000, Pavel Begunkov wrote:
    >> It's inlined and the on-stack iter is completely optimised out. Frankly,
    >> I'd rather not open-code bvec_iter_advance(), at least for this chunk to
    >> be findable from bvec.h, e.g. grep bvec_iter and bvec_for_each. Though,
    >> I don't like myself that preamble/postamble.
    >
    > Ok. I still think we at least want a separate helper instead of
    > bloating the main iov_iter_advance.

    I agree on that, just haven't got back to it yet.

    --
    Pavel Begunkov

    \
     
     \ /
      Last update: 2020-12-09 13:12    [W:3.070 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site