Messages in this thread | | | Subject | Re: [PATCH 1/3] x86/resctrl: Move setting task's active CPU in a mask into helpers | From | Reinette Chatre <> | Date | Tue, 8 Dec 2020 08:35:09 -0800 |
| |
Hi Borislav,
On 12/8/2020 1:49 AM, Borislav Petkov wrote: > On Mon, Dec 07, 2020 at 01:24:51PM -0800, Reinette Chatre wrote: >> How about: >> "Move the setting of the CPU on which a task is running in a CPU mask into a >> couple of helpers. >> >> There is no functional change. This is a preparatory change for the fix in >> the following patch from where the Fixes tag is copied." > > Almost. Just not call it a "following patch" because once this is > applied, the following one might be a different one depending on the > ordering a git command has requested. So a "later patch" would be > probably better.
Indeed, will do. Thank you.
> >> Correct. I will add it. The addition to the commit message above aims to >> explain a Fixes tag to a patch with no functional changes. > > Yes but you need to tell the stable people somehow that this one is a > prerequisite and that they should pick it up too.
Right. Thanks for guiding here.
> > Unless you can reorg your code this way that you don't need patch 1...
I think that the current organization, with patch 1 containing the preparatory work without functional changes, makes the fix in patch 2 easier to review. I thus plan to keep the code organization as is while surely following your suggestion on how to support the stable team.
Thank you very much
Reinette
| |