Messages in this thread | | | Subject | Re: [PATCH v3] erofs: avoiding using generic_block_bmap | From | Chao Yu <> | Date | Wed, 9 Dec 2020 10:56:20 +0800 |
| |
On 2020/12/9 10:44, Gao Xiang wrote: > Hi Jianan and Chao, > > On Wed, Dec 09, 2020 at 10:34:54AM +0800, Huang Jianan wrote: >> >> 在 2020/12/8 21:11, Huang Jianan 写道: > > ... > >>> - >>> static sector_t erofs_bmap(struct address_space *mapping, sector_t block) >>> { >>> struct inode *inode = mapping->host; >>> + struct erofs_map_blocks map = { >>> + .m_la = blknr_to_addr(iblock), >> >> Sorry for my mistake, it should be: >> >> .m_la = blknr_to_addr(block), >> > > Sigh, since my ro_fsstress doesn't cover bmap interface... I mean do we need > to add some testcase for this? (But it needs to be fixed anyway, plus this patch > looks good to me....) > > Hi Chao, > could you kindly leave some free slot for this patch and > > erofs: force inplace I/O under low memory scenario > https://lore.kernel.org/r/20201208054600.16302-1-hsiangkao@aol.com
Will review soon. :)
Thanks,
> > Since I'd like to merge these all for 5.11-rc1 (so we could have more time to > test until the next LTS version), since 5.10 is a LTS version, I tend to not > introduce any big modification (so in the past months, "erofs: force inplace > I/O under low memory scenario" never upstreamed at all.) > > Thanks, > Gao Xiang > > > . >
| |