lkml.org 
[lkml]   [2020]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 1/7] mm: memcontrol: fix NR_ANON_THPS account
    On Tue, Dec 08, 2020 at 12:18:41PM +0800, Muchun Song wrote:
    > The unit of NR_ANON_THPS is HPAGE_PMD_NR already. So it should inc/dec
    > by one rather than nr_pages.
    >
    > Fixes: 468c398233da ("mm: memcontrol: switch to native NR_ANON_THPS counter")
    > Signed-off-by: Muchun Song <songmuchun@bytedance.com>
    > Acked-by: Michal Hocko <mhocko@suse.com>

    Reviewed-by: Roman Gushchin <guro@fb.com>

    Thanks!


    > ---
    > mm/memcontrol.c | 6 ++----
    > 1 file changed, 2 insertions(+), 4 deletions(-)
    >
    > diff --git a/mm/memcontrol.c b/mm/memcontrol.c
    > index b80328f52fb4..8818bf64d6fe 100644
    > --- a/mm/memcontrol.c
    > +++ b/mm/memcontrol.c
    > @@ -5653,10 +5653,8 @@ static int mem_cgroup_move_account(struct page *page,
    > __mod_lruvec_state(from_vec, NR_ANON_MAPPED, -nr_pages);
    > __mod_lruvec_state(to_vec, NR_ANON_MAPPED, nr_pages);
    > if (PageTransHuge(page)) {
    > - __mod_lruvec_state(from_vec, NR_ANON_THPS,
    > - -nr_pages);
    > - __mod_lruvec_state(to_vec, NR_ANON_THPS,
    > - nr_pages);
    > + __dec_lruvec_state(from_vec, NR_ANON_THPS);
    > + __inc_lruvec_state(to_vec, NR_ANON_THPS);
    > }
    >
    > }
    > --
    > 2.11.0
    >

    \
     
     \ /
      Last update: 2020-12-09 03:01    [W:4.086 / U:0.296 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site