lkml.org 
[lkml]   [2020]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[RFC PATCH 14/14] WIP/cxl/mem: Add get firmware for testing
Date
This also serves as an example how to add a new command

Signed-off-by: Ben Widawsky <ben.widawsky@intel.com>
---
drivers/cxl/mem.c | 22 ++++++++++++++++++++++
include/uapi/linux/cxl_mem.h | 3 ++-
2 files changed, 24 insertions(+), 1 deletion(-)

diff --git a/drivers/cxl/mem.c b/drivers/cxl/mem.c
index 6b2f8d3776b5..76aa1e6e4117 100644
--- a/drivers/cxl/mem.c
+++ b/drivers/cxl/mem.c
@@ -116,6 +116,7 @@ struct cxl_mem_command {
static struct cxl_mem_command mem_commands[] = {
CXL_CMD(INVALID, NONE, 0, 0, "Reserved", false, 0),
CXL_CMD(RAW, TAINT, ~0, ~0, "Raw", true, 0),
+ CXL_CMD(GET_FW_INFO, NONE, 0, 0x50, "Get FW Info", false, 0x0200),
};

static int cxl_mem_wait_for_doorbell(struct cxl_mem *cxlm)
@@ -827,6 +828,23 @@ static int cxl_mem_add_memdev(struct cxl_mem *cxlm)
return cxl_register(dev);
}

+static int cxl_mem_enable_commands(struct cxl_mem *cxlm)
+{
+ struct cxl_mem_command *c;
+
+ /*
+ * For now we pretend Get FW info is supported.
+ *
+ * FIXME: Invoke GET LOG to get the Command Effect Logs (CEL).
+ */
+ c = cxl_mem_find_command(0x200);
+ if (!c)
+ return -ENOENT;
+
+ c->enable = true;
+ return 0;
+}
+
/**
* cxl_mem_identify() - Send the IDENTIFY command to the device.
* @cxlm: The device to identify.
@@ -936,6 +954,10 @@ static int cxl_mem_probe(struct pci_dev *pdev, const struct pci_device_id *id)
if (rc)
return rc;

+ rc = cxl_mem_enable_commands(cxlm);
+ if (rc)
+ return rc;
+
rc = cxl_mem_identify(cxlm);
if (rc)
return rc;
diff --git a/include/uapi/linux/cxl_mem.h b/include/uapi/linux/cxl_mem.h
index f2fbb0dcda06..3ac39acf8fa7 100644
--- a/include/uapi/linux/cxl_mem.h
+++ b/include/uapi/linux/cxl_mem.h
@@ -50,7 +50,8 @@ struct cxl_command_info {
__u32 id;
#define CXL_MEM_COMMAND_ID_INVALID 0
#define CXL_MEM_COMMAND_ID_RAW 1
-#define CXL_MEM_COMMAND_ID_MAX (CXL_MEM_COMMAND_ID_RAW + 1)
+#define CXL_MEM_COMMAND_ID_GET_FW_INFO 2
+#define CXL_MEM_COMMAND_ID_MAX (CXL_MEM_COMMAND_ID_GET_FW_INFO + 1)

__u32 flags;
#define CXL_MEM_COMMAND_FLAG_NONE 0
--
2.29.2
\
 
 \ /
  Last update: 2020-12-09 01:27    [W:0.635 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site