Messages in this thread | | | From | Thomas Gleixner <> | Subject | Re: [PATCH v3 1/4] irq: export kstat_irqs | Date | Sun, 06 Dec 2020 17:40:11 +0100 |
| |
On Sat, Dec 05 2020 at 12:39, Jarkko Sakkinen wrote: > On Fri, Dec 04, 2020 at 06:43:37PM -0700, Jerry Snitselaar wrote: >> To try and detect potential interrupt storms that >> have been occurring with tpm_tis devices it was suggested >> to use kstat_irqs() to get the number of interrupts. >> Since tpm_tis can be built as a module it needs kstat_irqs >> exported. > > I think you should also have a paragraph explicitly stating that > i915_pmu.c contains a duplicate of kstat_irqs() because it is not > exported as of today. It adds a lot more weight to this given that > there is already existing mainline usage (kind of).
It's abusage and just the fact that it exists is not an argument by itself.
Thanks,
tglx
| |