lkml.org 
[lkml]   [2020]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 00/20] ethernet: ucc_geth: assorted fixes and simplifications
    On Sat,  5 Dec 2020 20:17:23 +0100 Rasmus Villemoes wrote:
    > While trying to figure out how to allow bumping the MTU with the
    > ucc_geth driver, I fell into a rabbit hole and stumbled on a whole
    > bunch of issues of varying importance - some are outright bug fixes,
    > while most are a matter of simplifying the code to make it more
    > accessible.
    >
    > At the end of digging around the code and data sheet to figure out how
    > it all works, I think the MTU issue might be fixed by a one-liner, but
    > I'm not sure it can be that simple. It does seem to work (ping -s X
    > works for larger values of X, and wireshark confirms that the packets
    > are not fragmented).
    >
    > Re patch 2, someone in NXP should check how the hardware actually
    > works and make an updated reference manual available.

    Looks like a nice clean up on a quick look.

    Please separate patches 1 and 11 (which are the two bug fixes I see)
    rebase (retest) and post them against the net tree:

    https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/

    so they are available for backports.

    The reset should go into net-next:

    https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/

    Please indicate the tree in the tag like [PATCH net] or [PATCH
    net-next] so the test bots know which base to use for testing.

    Thanks!

    \
     
     \ /
      Last update: 2020-12-05 21:55    [W:4.458 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site