Messages in this thread | | | Date | Sat, 5 Dec 2020 15:30:01 +0100 | From | Andrew Lunn <> | Subject | Re: [PATCH 3/7] net: macb: unprepare clocks in case of failure |
| |
On Fri, Dec 04, 2020 at 02:34:17PM +0200, Claudiu Beznea wrote: > Unprepare clocks in case of any failure in fu540_c000_clk_init().
Hi Claudiu
Nice patchset. Simple to understand. >
> +err_disable_clocks: > + clk_disable_unprepare(*tx_clk);
> + clk_disable_unprepare(*hclk); > + clk_disable_unprepare(*pclk); > + clk_disable_unprepare(*rx_clk); > + clk_disable_unprepare(*tsu_clk);
This looks correct, but it would be more symmetrical to add a
macb_clk_uninit()
function for the four main clocks. I'm surprised it does not already exist.
Andrew
| |