lkml.org 
[lkml]   [2020]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [External] Re: [PATCH 5/9] mm: memcontrol: convert NR_FILE_THPS account to pages
On Sat, Dec 5, 2020 at 10:09 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Sat, Dec 05, 2020 at 09:02:20PM +0800, Muchun Song wrote:
> > Converrt NR_FILE_THPS account to pages.
> >
> > Signed-off-by: Muchun Song <songmuchun@bytedance.com>
> > ---
> > drivers/base/node.c | 3 +--
> > fs/proc/meminfo.c | 2 +-
> > mm/filemap.c | 2 +-
> > mm/huge_memory.c | 3 ++-
> > mm/khugepaged.c | 2 +-
> > mm/memcontrol.c | 5 ++---
> > 6 files changed, 8 insertions(+), 9 deletions(-)
> >
> > diff --git a/drivers/base/node.c b/drivers/base/node.c
> > index 05c369e93e16..f6a9521bbcf8 100644
> > --- a/drivers/base/node.c
> > +++ b/drivers/base/node.c
> > @@ -466,8 +466,7 @@ static ssize_t node_read_meminfo(struct device *dev,
> > HPAGE_PMD_NR),
> > nid, K(node_page_state(pgdat, NR_SHMEM_PMDMAPPED) *
> > HPAGE_PMD_NR),
> > - nid, K(node_page_state(pgdat, NR_FILE_THPS) *
> > - HPAGE_PMD_NR),
> > + nid, K(node_page_state(pgdat, NR_FILE_THPS)),
>
> Again, is this changing a user-visable value?
>

Of course not.

In the previous, the NR_FILE_THPS account is like below:

__mod_lruvec_page_state(page, NR_FILE_THPS, 1);

With this patch, it is:

__mod_lruvec_page_state(page, NR_FILE_THPS, HPAGE_PMD_NR);

So the result is not changed from the view of user space.

Thanks.

--
Yours,
Muchun

\
 
 \ /
  Last update: 2020-12-05 19:39    [W:0.278 / U:0.752 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site