Messages in this thread | | | From | Bartosz Golaszewski <> | Date | Fri, 4 Dec 2020 21:23:50 +0100 | Subject | Re: [PATCH v3 2/4] configfs: use (1UL << bit) for internal flags |
| |
On Fri, Dec 4, 2020 at 8:06 PM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > > > On Friday, December 4, 2020, Bartosz Golaszewski <brgl@bgdev.pl> wrote: >> >> From: Bartosz Golaszewski <bgolaszewski@baylibre.com> >> >> For better readability and maintenance: use the (1UL << bit) for flag >> definitions. >> > > And I didn’t get why BIT can’t be used? > Maybe some elaboration? >
I agree that BIT() would be better and did try it in v2[1].
Bartosz
[1] https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg2398294.html
| |