Messages in this thread | | | From | Rafał Miłecki <> | Date | Fri, 4 Dec 2020 17:29:55 +0100 | Subject | Re: [PATCH 2/2] reset: bcm4908-usb: add driver for BCM4908 USB reset controller |
| |
On Fri, 4 Dec 2020 at 17:13, Philipp Zabel <p.zabel@pengutronix.de> wrote: > On Fri, 2020-12-04 at 10:37 +0100, Rafał Miłecki wrote: > > From: Rafał Miłecki <rafal@milecki.pl> > > > > This controller is responsible for OHCI, EHCI, XHCI and PHYs setup that > > has to be handled in the proper order. > > > > One unusual thing about this controller is that is provides access to > > the MDIO bus. There are two registers (in the middle of block space) > > responsible for that. For that reason this driver initializes regmap so > > a proper MDIO driver can use them. > > > > Signed-off-by: Rafał Miłecki <rafal@milecki.pl> > > This doesn't look like a reset controller to me, but rather like > something that belongs in drivers/usb.
I think I found the reset API to match the best setup requirements and assumed it should be treated as a reset controller.
Any advice, idea, how should I integrate this driver with the USB subsystem? Rested made it easy as all I needed was:
usb@c300 { compatible = "generic-ehci"; reg = <0xc300 0x100>; interrupts = <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>; resets = <&usb_reset>; };
-- Rafał
| |