lkml.org 
[lkml]   [2020]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] vhost scsi: fix error return code in vhost_scsi_set_endpoint()
From
Date
On 12/4/20 2:43 AM, Zhang Changzhong wrote:
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: 25b98b64e284 ("vhost scsi: alloc cmds per vq instead of session")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
> ---
> drivers/vhost/scsi.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
> index 6ff8a5096..4ce9f00 100644
> --- a/drivers/vhost/scsi.c
> +++ b/drivers/vhost/scsi.c
> @@ -1643,7 +1643,8 @@ vhost_scsi_set_endpoint(struct vhost_scsi *vs,
> if (!vhost_vq_is_setup(vq))
> continue;
>
> - if (vhost_scsi_setup_vq_cmds(vq, vq->num))
> + ret = vhost_scsi_setup_vq_cmds(vq, vq->num);
> + if (ret)
> goto destroy_vq_cmds;
> }
>
>

Reviewed-by: Mike Christie <michael.christie@oracle.com>

\
 
 \ /
  Last update: 2020-12-04 17:14    [W:0.430 / U:0.520 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site