Messages in this thread | | | Subject | Re: [PATCH] vhost scsi: fix error return code in vhost_scsi_set_endpoint() | From | Mike Christie <> | Date | Fri, 4 Dec 2020 10:12:07 -0600 |
| |
On 12/4/20 2:43 AM, Zhang Changzhong wrote: > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. > > Fixes: 25b98b64e284 ("vhost scsi: alloc cmds per vq instead of session") > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com> > --- > drivers/vhost/scsi.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c > index 6ff8a5096..4ce9f00 100644 > --- a/drivers/vhost/scsi.c > +++ b/drivers/vhost/scsi.c > @@ -1643,7 +1643,8 @@ vhost_scsi_set_endpoint(struct vhost_scsi *vs, > if (!vhost_vq_is_setup(vq)) > continue; > > - if (vhost_scsi_setup_vq_cmds(vq, vq->num)) > + ret = vhost_scsi_setup_vq_cmds(vq, vq->num); > + if (ret) > goto destroy_vq_cmds; > } > >
Reviewed-by: Mike Christie <michael.christie@oracle.com>
| |