Messages in this thread | | | Date | Fri, 4 Dec 2020 09:24:30 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH] tools build: Add missing libcap to test-all.bin target |
| |
Em Fri, Dec 04, 2020 at 12:08:36AM +0100, Jiri Olsa escreveu: > We're missing -lcap in test-all.bin target, so in case it's > the only library missing (if more are missing test-all.bin > fails anyway), we will falsely claim that we detected it and > fail build, like:
Thanks, applied.
- Arnaldo
> $ make > ... > Auto-detecting system features: > ... dwarf: [ on ] > ... dwarf_getlocations: [ on ] > ... glibc: [ on ] > ... libbfd: [ on ] > ... libbfd-buildid: [ on ] > ... libcap: [ on ] > ... libelf: [ on ] > ... libnuma: [ on ] > ... numa_num_possible_cpus: [ on ] > ... libperl: [ on ] > ... libpython: [ on ] > ... libcrypto: [ on ] > ... libunwind: [ on ] > ... libdw-dwarf-unwind: [ on ] > ... zlib: [ on ] > ... lzma: [ on ] > ... get_cpuid: [ on ] > ... bpf: [ on ] > ... libaio: [ on ] > ... libzstd: [ on ] > ... disassembler-four-args: [ on ] > > ... > > CC builtin-ftrace.o > > In file included from builtin-ftrace.c:29: > util/cap.h:11:10: fatal error: sys/capability.h: No such file or directory > 11 | #include <sys/capability.h> > | ^~~~~~~~~~~~~~~~~~ > compilation terminated. > > Signed-off-by: Jiri Olsa <jolsa@kernel.org> > --- > tools/build/feature/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/build/feature/Makefile b/tools/build/feature/Makefile > index cdde783f3018..89ba522e377d 100644 > --- a/tools/build/feature/Makefile > +++ b/tools/build/feature/Makefile > @@ -90,7 +90,7 @@ __BUILDXX = $(CXX) $(CXXFLAGS) -MD -Wall -Werror -o $@ $(patsubst %.bin,%.cpp,$( > ############################### > > $(OUTPUT)test-all.bin: > - $(BUILD) -fstack-protector-all -O2 -D_FORTIFY_SOURCE=2 -ldw -lelf -lnuma -lelf -I/usr/include/slang -lslang $(FLAGS_PERL_EMBED) $(FLAGS_PYTHON_EMBED) -DPACKAGE='"perf"' -lbfd -ldl -lz -llzma -lzstd > + $(BUILD) -fstack-protector-all -O2 -D_FORTIFY_SOURCE=2 -ldw -lelf -lnuma -lelf -I/usr/include/slang -lslang $(FLAGS_PERL_EMBED) $(FLAGS_PYTHON_EMBED) -DPACKAGE='"perf"' -lbfd -ldl -lz -llzma -lzstd -lcap > > $(OUTPUT)test-hello.bin: > $(BUILD) > -- > 2.26.2 >
--
- Arnaldo
| |