| Subject | Re: [PATCH bpf-next v3 07/14] bpf: Add BPF_FETCH field / create atomic_fetch_add instruction | From | Yonghong Song <> | Date | Thu, 3 Dec 2020 21:02:49 -0800 |
| |
On 12/3/20 8:02 AM, Brendan Jackman wrote: > This value can be set in bpf_insn.imm, for BPF_ATOMIC instructions,
it is not clear what "this value" means here. Maybe more specific using "The BPF_FETCH field"?
> in order to have the previous value of the atomically-modified memory > location loaded into the src register after an atomic op is carried > out. > > Suggested-by: Yonghong Song <yhs@fb.com> > Signed-off-by: Brendan Jackman <jackmanb@google.com>
Ack with the above nit.
Acked-by: Yonghong Song <yhs@fb.com>
|