lkml.org 
[lkml]   [2020]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] sched: Split the function show_schedstat()
On Fri, Dec 04, 2020 at 09:22:34AM +0800, Yunfeng Ye wrote:
>
>
> On 2020/12/3 17:42, Mel Gorman wrote:
> > On Thu, Dec 03, 2020 at 02:47:14PM +0800, Yunfeng Ye wrote:
> >> The schedstat include runqueue-specific stats and domain-specific stats,
> >> so split it into two functions, show_rqstat() and show_domainstat().
> >>
> >> No functional changes.
> >>
> >> Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com>
> >
> > Why?
> >
> > I could understand if there was a follow-up patch that adjusted some
> > subset or there was a difference in checking for schedstat_enabled,
> > locking or inserting new schedstat information. This can happen in the
> > general case when the end result is easier to review here it seems to be
> > just moving code around.
> >
> The rqstat and domainstat is independent state information. so I think
> split it into two individual function is clearer.
>

The comments and the names of the structures being accessesd is sufficient
to make it clear.

--
Mel Gorman
SUSE Labs

\
 
 \ /
  Last update: 2020-12-04 10:42    [W:0.081 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site