Messages in this thread | | | From | Richard Weinberger <> | Date | Fri, 4 Dec 2020 09:52:52 +0100 | Subject | Re: [PATCH v2] phram: Allow the user to set the erase page size. |
| |
On Wed, Nov 25, 2020 at 8:14 AM Guohua Zhong <zhongguohua1@huawei.com> wrote: > > Permit the user to specify the erase page size as a parameter. > This solves two problems: > > - phram can access images made by mkfs.jffs2. mkfs.jffs2 won't > create images with erase sizes less than 8KiB; many architectures > define PAGE_SIZE as 4KiB. > > - Allows more effective use of small capacity devices. JFFS2 > needs somewhere between 2 and 5 empty pages for garbage collection; > and for an NVRAM part with only 32KiB of space, a smaller erase page > allows much better utilization in applications where garbage collection > is important. > > Signed-off-by: Patrick O'Grady <patrick@baymotion.com> > Reviewed-by: Joern Engel <joern@logfs.org> > Link: https://lore.kernel.org/lkml/CAJ7m5OqYv_=JB9NhHsqBsa8YU0DFRoP7C+W10PY22wonAGJK=A@mail.gmail.com/ > [Guohua Zhong: fix token array index out of bounds and update patch for kernel master branch] > Signed-off-by: Guohua Zhong <zhongguohua1@huawei.com> > Reported-by: kernel test robot <lkp@intel.com>
Looks good to me, except the authorship. If I understand correctly, you took this old patch and resend it. Please make sure that the "From:"-Line contains the original author. You can fix this up using git commit --amend --author=. The git format-patch will create a correct patch.
-- Thanks, //richard
| |