lkml.org 
[lkml]   [2020]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/3] scsi: ufs: Keep device power on only fWriteBoosterBufferFlushDuringHibernate == 1
From
Date
On Fri, 2020-12-04 at 11:26 +0800, Can Guo wrote:
> >
> > if (!ufshcd_is_wb_allowed(hba))
> > return false;
> > +
> > + if (!hba->dev_info.is_hibern8_wb_flush)
> > + return false;
>
> The check is in the wrong place - even if say
> fWriteBoosterBufferFlushDuringHibernate is failed to be enabled,
> ufshcd_wb_need_flush() still needs to reflect the fact that whether
> the wb buffer needs to be flushed or not - it should not be decided
> by the flag.
>
Can,
you are right, let me take it out from this function, and see if
acceptable.

Thanks,
Bean

> Thanks,
>
> Can Guo.

\
 
 \ /
  Last update: 2020-12-04 09:31    [W:0.110 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site