lkml.org 
[lkml]   [2020]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] drivers: usb: storage: prefer pr_*() macros over bare printk()
On Thu, Dec 03, 2020 at 03:16:34PM +0100, Enrico Weigelt, metux IT consult wrote:
> pr_*() printing helpers are preferred over using bare printk().
>
> changes v2: fixed ugly typo

Don't put that in the changelog, it goes below the --- line, as is
documented.



>
> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
> ---
> drivers/usb/storage/alauda.c | 23 ++++++++------------
> drivers/usb/storage/ene_ub6250.c | 20 ++++++++---------
> drivers/usb/storage/freecom.c | 2 +-
> drivers/usb/storage/sddr09.c | 46 +++++++++++++++++-----------------------
> drivers/usb/storage/sddr55.c | 7 +++---
> 5 files changed, 43 insertions(+), 55 deletions(-)
>
> diff --git a/drivers/usb/storage/alauda.c b/drivers/usb/storage/alauda.c
> index 20b857e97e60..5806f1bee471 100644
> --- a/drivers/usb/storage/alauda.c
> +++ b/drivers/usb/storage/alauda.c
> @@ -622,9 +622,8 @@ static int alauda_read_map(struct us_data *us, unsigned int zone)
>
> /* check even parity */
> if (parity[data[6] ^ data[7]]) {
> - printk(KERN_WARNING
> - "alauda_read_map: Bad parity in LBA for block %d"
> - " (%02X %02X)\n", i, data[6], data[7]);
> + pr_warn("alauda_read_map: Bad parity in LBA for block %d"
> + " (%02X %02X)\n", i, data[6], data[7]);

Please use dev_warn() and friends instead. This is a driver, it has a
device, it should never use "raw" printk, or pr_* calls.

thanks,

greg k-h

\
 
 \ /
  Last update: 2020-12-03 16:22    [W:0.031 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site