Messages in this thread | | | From | Yash Shah <> | Subject | RE: [PATCH 1/4] dt-bindings: riscv: Update DT binding docs to support SiFive FU740 SoC | Date | Thu, 3 Dec 2020 06:36:32 +0000 |
| |
> -----Original Message----- > From: Andrew Lunn <andrew@lunn.ch> > Sent: 02 December 2020 20:28 > To: Yash Shah <yash.shah@openfive.com> > Cc: linux-spi@vger.kernel.org; linux-serial@vger.kernel.org; linux- > pwm@vger.kernel.org; linux-i2c@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-riscv@lists.infradead.org; > devicetree@vger.kernel.org; linux-gpio@vger.kernel.org; > broonie@kernel.org; gregkh@linuxfoundation.org; aou@eecs.berkeley.edu; > lee.jones@linaro.org; u.kleine-koenig@pengutronix.de; > thierry.reding@gmail.com; peter@korsgaard.com; Paul Walmsley ( Sifive) > <paul.walmsley@sifive.com>; palmer@dabbelt.com; robh+dt@kernel.org; > bgolaszewski@baylibre.com; linus.walleij@linaro.org; Sachin Ghadi > <sachin.ghadi@openfive.com> > Subject: Re: [PATCH 1/4] dt-bindings: riscv: Update DT binding docs to > support SiFive FU740 SoC > > [External Email] Do not click links or attachments unless you recognize the > sender and know the content is safe > > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-ocores.txt > > b/Documentation/devicetree/bindings/i2c/i2c-ocores.txt > > index 6b25a80..1966b2c 100644 > > --- a/Documentation/devicetree/bindings/i2c/i2c-ocores.txt > > +++ b/Documentation/devicetree/bindings/i2c/i2c-ocores.txt > > @@ -3,9 +3,11 @@ Device tree configuration for i2c-ocores Required > > properties: > > - compatible : "opencores,i2c-ocores" > > "aeroflexgaisler,i2cmst" > > - "sifive,fu540-c000-i2c", "sifive,i2c0" > > + "sifive,<chip>-i2c", "sifive,i2c0" > > Please make this a full list. At some point, this file will get turned into yaml, at > which point substitution like this will need expanding. It is better to do that > now.
Ok sure, will do that in patch v2.
- Yash
> > Andrew
| |