lkml.org 
[lkml]   [2020]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 4/5] amba: Make the remove callback return void
On Thu, Dec 03, 2020 at 02:01:41PM +0100, Uwe Kleine-König wrote:
> Hello,
>
> [This is a resend because somehow my MUA failed to parse the To: list
> and dropped it without me noticing it. Sorry to those who got it twice
> now.]
>
> On Tue, Nov 24, 2020 at 02:31:38PM +0100, Uwe Kleine-König wrote:
> > From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> >
> > All amba drivers return 0 in their remove callback. Together with the
> > driver core ignoring the return value anyhow, it doesn't make sense to
> > return a value here.
> >
> > Change the remove prototype to return void, which makes it explicit that
> > returning an error value doesn't work as expected. This simplifies changing
> > the core remove callback to return void, too.
> >
> > Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
> > Reviewed-by: Arnd Bergmann <arnd@arndb.de>
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > ---
> > drivers/amba/bus.c | 5 ++---
> > drivers/char/hw_random/nomadik-rng.c | 3 +--
> > drivers/dma/pl330.c | 3 +--
> > drivers/gpu/drm/pl111/pl111_drv.c | 4 +---
> > drivers/hwtracing/coresight/coresight-catu.c | 3 +--
> > drivers/hwtracing/coresight/coresight-cpu-debug.c | 4 +---
> > drivers/hwtracing/coresight/coresight-cti-core.c | 4 +---
> > drivers/hwtracing/coresight/coresight-etb10.c | 4 +---
> > drivers/hwtracing/coresight/coresight-etm3x-core.c | 4 +---
> > drivers/hwtracing/coresight/coresight-etm4x-core.c | 4 +---
> > drivers/hwtracing/coresight/coresight-funnel.c | 4 ++--
> > drivers/hwtracing/coresight/coresight-replicator.c | 4 ++--
> > drivers/hwtracing/coresight/coresight-stm.c | 4 +---
> > drivers/hwtracing/coresight/coresight-tmc-core.c | 4 +---
> > drivers/hwtracing/coresight/coresight-tpiu.c | 4 +---
> > drivers/i2c/busses/i2c-nomadik.c | 4 +---
> > drivers/input/serio/ambakmi.c | 3 +--
> > drivers/memory/pl172.c | 4 +---
> > drivers/memory/pl353-smc.c | 4 +---

For the memory:
Acked-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2020-12-03 15:13    [W:0.463 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site