Messages in this thread Patch in this message | | | Date | Thu, 03 Dec 2020 23:47:48 -0000 | From | "tip-bot2 for Daniel Lezcano" <> | Subject | [tip: timers/core] clocksource/drivers/ingenic: Fix section mismatch |
| |
The following commit has been merged into the timers/core branch of tip:
Commit-ID: 5bd7cb29eceb52e4b108917786fdbf2a2c2048ef Gitweb: https://git.kernel.org/tip/5bd7cb29eceb52e4b108917786fdbf2a2c2048ef Author: Daniel Lezcano <daniel.lezcano@linaro.org> AuthorDate: Wed, 25 Nov 2020 11:23:45 +01:00 Committer: Daniel Lezcano <daniel.lezcano@linaro.org> CommitterDate: Thu, 03 Dec 2020 19:16:26 +01:00
clocksource/drivers/ingenic: Fix section mismatch
The function ingenic_tcu_get_clock() is annotated for the __init section but it is actually called from the online cpu callback.
That will lead to a crash if a CPU is hotplugged after boot time.
Remove the __init annotation for the ingenic_tcu_get_clock() function.
Fixes: f19d838d08fc (clocksource/drivers/ingenic: Add high resolution timer support for SMP/SMT) Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> Reviewed-by: Paul Cercueil <paul@crapouillou.net> Tested-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com> Link: https://lore.kernel.org/r/20201125102346.1816310-1-daniel.lezcano@linaro.org --- drivers/clocksource/ingenic-timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clocksource/ingenic-timer.c b/drivers/clocksource/ingenic-timer.c index 58fd918..905fd6b 100644 --- a/drivers/clocksource/ingenic-timer.c +++ b/drivers/clocksource/ingenic-timer.c @@ -127,7 +127,7 @@ static irqreturn_t ingenic_tcu_cevt_cb(int irq, void *dev_id) return IRQ_HANDLED; } -static struct clk * __init ingenic_tcu_get_clock(struct device_node *np, int id) +static struct clk *ingenic_tcu_get_clock(struct device_node *np, int id) { struct of_phandle_args args;
| |