lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 065/242] drm/gma500: fix double free of gma_connector
    Date
    From: Tom Rix <trix@redhat.com>

    [ Upstream commit 4e19d51ca5b28a1d435a844c7b2a8e1b1b6fa237 ]

    clang static analysis reports this problem:

    cdv_intel_dp.c:2101:2: warning: Attempt to free released memory
    kfree(gma_connector);
    ^~~~~~~~~~~~~~~~~~~~

    In cdv_intel_dp_init() when the call to cdv_intel_edp_panel_vdd_off()
    fails, the handler calls cdv_intel_dp_destroy(connector) which does
    the first free of gma_connector. So adjust the goto label and skip
    the second free.

    Fixes: d112a8163f83 ("gma500/cdv: Add eDP support")
    Signed-off-by: Tom Rix <trix@redhat.com>
    Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
    Link: https://patchwork.freedesktop.org/patch/msgid/20201003193928.18869-1-trix@redhat.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/gma500/cdv_intel_dp.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/gma500/cdv_intel_dp.c b/drivers/gpu/drm/gma500/cdv_intel_dp.c
    index 7ec4e3fbafd8c..ec6ea202cf5de 100644
    --- a/drivers/gpu/drm/gma500/cdv_intel_dp.c
    +++ b/drivers/gpu/drm/gma500/cdv_intel_dp.c
    @@ -2126,7 +2126,7 @@ cdv_intel_dp_init(struct drm_device *dev, struct psb_intel_mode_device *mode_dev
    DRM_INFO("failed to retrieve link info, disabling eDP\n");
    cdv_intel_dp_encoder_destroy(encoder);
    cdv_intel_dp_destroy(connector);
    - goto err_priv;
    + goto err_connector;
    } else {
    DRM_DEBUG_KMS("DPCD: Rev=%x LN_Rate=%x LN_CNT=%x LN_DOWNSP=%x\n",
    intel_dp->dpcd[0], intel_dp->dpcd[1],
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 14:40    [W:2.392 / U:0.180 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site