lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 245/346] pwm: zx: Add missing cleanup in error path
    Date
    From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

    [ Upstream commit 269effd03f6142df4c74814cfdd5f0b041b30bf9 ]

    zx_pwm_probe() called clk_prepare_enable() before; this must be undone
    in the error path.

    Fixes: 4836193c435c ("pwm: Add ZTE ZX PWM device driver")
    Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    Acked-by: Shawn Guo <shawn.guo@linaro.org>
    Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/pwm/pwm-zx.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/pwm/pwm-zx.c b/drivers/pwm/pwm-zx.c
    index 5d27c16edfb13..0d4112410b69d 100644
    --- a/drivers/pwm/pwm-zx.c
    +++ b/drivers/pwm/pwm-zx.c
    @@ -241,6 +241,7 @@ static int zx_pwm_probe(struct platform_device *pdev)
    ret = pwmchip_add(&zpc->chip);
    if (ret < 0) {
    dev_err(&pdev->dev, "failed to add PWM chip: %d\n", ret);
    + clk_disable_unprepare(zpc->pclk);
    return ret;
    }

    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 14:35    [W:2.726 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site