lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 175/242] clk: s2mps11: Fix a resource leak in error handling paths in the probe function
    Date
    From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

    [ Upstream commit d2d94fc567624f96187e8b52083795620f93e69f ]

    Some resource should be released in the error handling path of the probe
    function, as already done in the remove function.

    The remove function was fixed in commit bf416bd45738 ("clk: s2mps11: Add
    missing of_node_put and of_clk_del_provider")

    Fixes: 7cc560dea415 ("clk: s2mps11: Add support for s2mps11")
    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    Link: https://lore.kernel.org/r/20201212122818.86195-1-christophe.jaillet@wanadoo.fr
    Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
    Signed-off-by: Stephen Boyd <sboyd@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/clk/clk-s2mps11.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/clk/clk-s2mps11.c b/drivers/clk/clk-s2mps11.c
    index f5d74e8db4327..1803af6230b27 100644
    --- a/drivers/clk/clk-s2mps11.c
    +++ b/drivers/clk/clk-s2mps11.c
    @@ -211,6 +211,7 @@ static int s2mps11_clk_probe(struct platform_device *pdev)
    return ret;

    err_reg:
    + of_node_put(s2mps11_clks[0].clk_np);
    while (--i >= 0)
    clkdev_drop(s2mps11_clks[i].lookup);

    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 14:18    [W:4.041 / U:1.200 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site