lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 152/242] speakup: fix uninitialized flush_lock
    Date
    From: Yang Yingliang <yangyingliang@huawei.com>

    [ Upstream commit d1b928ee1cfa965a3327bbaa59bfa005d97fa0fe ]

    The flush_lock is uninitialized, use DEFINE_SPINLOCK
    to define and initialize flush_lock.

    Fixes: c6e3fd22cd53 ("Staging: add speakup to the staging directory")
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
    Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
    Link: https://lore.kernel.org/r/20201117012229.3395186-1-yangyingliang@huawei.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/staging/speakup/speakup_dectlk.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/staging/speakup/speakup_dectlk.c b/drivers/staging/speakup/speakup_dectlk.c
    index f069954800226..53316b0c0b13c 100644
    --- a/drivers/staging/speakup/speakup_dectlk.c
    +++ b/drivers/staging/speakup/speakup_dectlk.c
    @@ -46,7 +46,7 @@ static unsigned char get_index(struct spk_synth *synth);
    static int in_escape;
    static int is_flushing;

    -static spinlock_t flush_lock;
    +static DEFINE_SPINLOCK(flush_lock);
    static DECLARE_WAIT_QUEUE_HEAD(flush);

    static struct var_t vars[] = {
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 14:15    [W:5.235 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site