lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 122/242] ath10k: Fix an error handling path
    Date
    From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

    [ Upstream commit ed3573bc3943c27d2d8e405a242f87ed14572ca1 ]

    If 'ath10k_usb_create()' fails, we should release some resources and report
    an error instead of silently continuing.

    Fixes: 4db66499df91 ("ath10k: add initial USB support")
    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
    Link: https://lore.kernel.org/r/20201122170342.1346011-1-christophe.jaillet@wanadoo.fr
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/wireless/ath/ath10k/usb.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/net/wireless/ath/ath10k/usb.c b/drivers/net/wireless/ath/ath10k/usb.c
    index c64a03f164c0f..f4e6d84bfb91c 100644
    --- a/drivers/net/wireless/ath/ath10k/usb.c
    +++ b/drivers/net/wireless/ath/ath10k/usb.c
    @@ -1019,6 +1019,8 @@ static int ath10k_usb_probe(struct usb_interface *interface,

    ar_usb = ath10k_usb_priv(ar);
    ret = ath10k_usb_create(ar, interface);
    + if (ret)
    + goto err;
    ar_usb->ar = ar;

    ar->dev_id = product_id;
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 14:14    [W:4.033 / U:0.204 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site