lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 013/242] kbuild: avoid static_assert for genksyms
    Date
    From: Arnd Bergmann <arnd@arndb.de>

    commit 14dc3983b5dff513a90bd5a8cc90acaf7867c3d0 upstream.

    genksyms does not know or care about the _Static_assert() built-in, and
    sometimes falls back to ignoring the later symbols, which causes
    undefined behavior such as

    WARNING: modpost: EXPORT symbol "ethtool_set_ethtool_phy_ops" [vmlinux] version generation failed, symbol will not be versioned.
    ld: net/ethtool/common.o: relocation R_AARCH64_ABS32 against `__crc_ethtool_set_ethtool_phy_ops' can not be used when making a shared object
    net/ethtool/common.o:(_ftrace_annotated_branch+0x0): dangerous relocation: unsupported relocation

    Redefine static_assert for genksyms to avoid that.

    Link: https://lkml.kernel.org/r/20201203230955.1482058-1-arnd@kernel.org
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    Suggested-by: Ard Biesheuvel <ardb@kernel.org>
    Cc: Masahiro Yamada <masahiroy@kernel.org>
    Cc: Michal Marek <michal.lkml@markovi.net>
    Cc: Kees Cook <keescook@chromium.org>
    Cc: Rikard Falkeborn <rikard.falkeborn@gmail.com>
    Cc: Marco Elver <elver@google.com>
    Cc: <stable@vger.kernel.org>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    include/linux/build_bug.h | 5 +++++
    1 file changed, 5 insertions(+)

    --- a/include/linux/build_bug.h
    +++ b/include/linux/build_bug.h
    @@ -82,4 +82,9 @@

    #endif /* __CHECKER__ */

    +#ifdef __GENKSYMS__
    +/* genksyms gets confused by _Static_assert */
    +#define _Static_assert(expr, ...)
    +#endif
    +
    #endif /* _LINUX_BUILD_BUG_H */

    \
     
     \ /
      Last update: 2020-12-28 14:11    [W:4.130 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site