Messages in this thread | | | Subject | Re: [PATCH 8455/8455] staging: rtl8188eu: core: fixed a comment format issue. | From | Joe Perches <> | Date | Mon, 28 Dec 2020 11:47:27 -0800 |
| |
On Mon, 2020-12-28 at 15:09 +0100, Greg KH wrote: > On Sat, Dec 19, 2020 at 02:43:12PM -0800, Daniel West wrote: > > Fixed a checkpatch warning: > > > > WARNING: Block comments use * on subsequent lines > > #4595: FILE: drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:4595: > > +/**************************************************************************** > > + > > > > The code is full of comments like this. Should the coding style > > be inforced here, even when there is a logic to the way the code > > was broken up? [] > > diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c [] > > @@ -4591,11 +4591,10 @@ void mlmeext_sta_del_event_callback(struct adapter *padapter) > > } > > } > > > > > > -/**************************************************************************** > > - > > -Following are the functions for the timer handlers > > - > > -*****************************************************************************/ > > +/* > > + * > > + *Following are the functions for the timer handlers > > + */ > > Does that look correct? Make it all one line please.
Just:
/* timer handler functions */
would be simpler.
And the code is mostly a horror to read.
| |