lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 039/132] spi: tegra20-slink: fix reference leak in slink ops of tegra20
    Date
    From: Zhang Qilong <zhangqilong3@huawei.com>

    [ Upstream commit 763eab7074f6e71babd85d796156f05a675f9510 ]

    pm_runtime_get_sync will increment pm usage counter even it
    failed. Forgetting to pm_runtime_put_noidle will result in
    reference leak in two callers(tegra_slink_setup and
    tegra_slink_resume), so we should fix it.

    Fixes: dc4dc36056392 ("spi: tegra: add spi driver for SLINK controller")
    Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
    Link: https://lore.kernel.org/r/20201103141345.6188-1-zhangqilong3@huawei.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/spi/spi-tegra20-slink.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/spi/spi-tegra20-slink.c b/drivers/spi/spi-tegra20-slink.c
    index cf2a329fd8958..9f14560686b68 100644
    --- a/drivers/spi/spi-tegra20-slink.c
    +++ b/drivers/spi/spi-tegra20-slink.c
    @@ -761,6 +761,7 @@ static int tegra_slink_setup(struct spi_device *spi)

    ret = pm_runtime_get_sync(tspi->dev);
    if (ret < 0) {
    + pm_runtime_put_noidle(tspi->dev);
    dev_err(tspi->dev, "pm runtime failed, e = %d\n", ret);
    return ret;
    }
    @@ -1197,6 +1198,7 @@ static int tegra_slink_resume(struct device *dev)

    ret = pm_runtime_get_sync(dev);
    if (ret < 0) {
    + pm_runtime_put_noidle(dev);
    dev_err(dev, "pm runtime failed, e = %d\n", ret);
    return ret;
    }
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 17:49    [W:4.117 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site