lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 081/175] cw1200: fix missing destroy_workqueue() on error in cw1200_init_common
    Date
    From: Qinglang Miao <miaoqinglang@huawei.com>

    [ Upstream commit 7ec8a926188eb8e7a3cbaca43ec44f2d7146d71b ]

    Add the missing destroy_workqueue() before return from
    cw1200_init_common in the error handling case.

    Fixes: a910e4a94f69 ("cw1200: add driver for the ST-E CW1100 & CW1200 WLAN chipsets")
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
    Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
    Link: https://lore.kernel.org/r/20201119070842.1011-1-miaoqinglang@huawei.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/wireless/st/cw1200/main.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/net/wireless/st/cw1200/main.c b/drivers/net/wireless/st/cw1200/main.c
    index 84624c812a15f..f4338bce78f4a 100644
    --- a/drivers/net/wireless/st/cw1200/main.c
    +++ b/drivers/net/wireless/st/cw1200/main.c
    @@ -385,6 +385,7 @@ static struct ieee80211_hw *cw1200_init_common(const u8 *macaddr,
    CW1200_LINK_ID_MAX,
    cw1200_skb_dtor,
    priv)) {
    + destroy_workqueue(priv->workqueue);
    ieee80211_free_hw(hw);
    return NULL;
    }
    @@ -396,6 +397,7 @@ static struct ieee80211_hw *cw1200_init_common(const u8 *macaddr,
    for (; i > 0; i--)
    cw1200_queue_deinit(&priv->tx_queue[i - 1]);
    cw1200_queue_stats_deinit(&priv->tx_queue_stats);
    + destroy_workqueue(priv->workqueue);
    ieee80211_free_hw(hw);
    return NULL;
    }
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 14:05    [W:4.041 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site