lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 222/346] bus: fsl-mc: fix error return code in fsl_mc_object_allocate()
    Date
    From: Zhang Changzhong <zhangchangzhong@huawei.com>

    [ Upstream commit 3d70fb03711c37bc64e8e9aea5830f498835f6bf ]

    Fix to return a negative error code from the error handling
    case instead of 0, as done elsewhere in this function.

    Fixes: 197f4d6a4a00 ("staging: fsl-mc: fsl-mc object allocator driver")
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Acked-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
    Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
    Link: https://lore.kernel.org/r/1607068967-31991-1-git-send-email-zhangchangzhong@huawei.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/bus/fsl-mc/fsl-mc-allocator.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/bus/fsl-mc/fsl-mc-allocator.c b/drivers/bus/fsl-mc/fsl-mc-allocator.c
    index e906ecfe23dd8..9cb0733a03991 100644
    --- a/drivers/bus/fsl-mc/fsl-mc-allocator.c
    +++ b/drivers/bus/fsl-mc/fsl-mc-allocator.c
    @@ -292,8 +292,10 @@ int __must_check fsl_mc_object_allocate(struct fsl_mc_device *mc_dev,
    goto error;

    mc_adev = resource->data;
    - if (!mc_adev)
    + if (!mc_adev) {
    + error = -EINVAL;
    goto error;
    + }

    *new_mc_adev = mc_adev;
    return 0;
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 17:01    [W:4.681 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site