Messages in this thread | | | Date | Thu, 24 Dec 2020 21:21:53 +0100 | From | Simon Horman <> | Subject | Re: [PATCH] nfp: remove h from printk format specifier |
| |
On Wed, Dec 23, 2020 at 12:20:53PM -0800, trix@redhat.com wrote: > From: Tom Rix <trix@redhat.com> > > This change fixes the checkpatch warning described in this commit > commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]") > > Standard integer promotion is already done and %hx and %hhx is useless > so do not encourage the use of %hh[xudi] or %h[xudi]. > > Signed-off-by: Tom Rix <trix@redhat.com>
Hi Tom,
This patch looks appropriate for net-next, which is currently closed.
The changes look fine, but I'm curious to know if its intentionally that the following was left alone in ethernet/netronome/nfp/nfp_net_ethtool.c:nfp_net_get_nspinfo()
snprintf(version, ETHTOOL_FWVERS_LEN, "%hu.%hu"
If the above was not intentional then perhaps you could respin with that updated and resubmit when net-next re-opens. Feel free to add:
Reviewed-by: Simon Horman <simon.horman@netronome.com>
| |