lkml.org 
[lkml]   [2020]   [Dec]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.9 03/48] crypto: omap-aes - fix the reference count leak of omap device
    Date
    From: Zhang Qilong <zhangqilong3@huawei.com>

    [ Upstream commit 383e8a823014532ffd81c787ef9009f1c2bd3b79 ]

    pm_runtime_get_sync() will increment pm usage counter even
    when it returns an error code. We should call put operation
    in error handling paths of omap_aes_hw_init.

    Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/crypto/omap-aes.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c
    index fe32dd95ae4ff..717cde167873a 100644
    --- a/drivers/crypto/omap-aes.c
    +++ b/drivers/crypto/omap-aes.c
    @@ -251,6 +251,7 @@ static int omap_aes_hw_init(struct omap_aes_dev *dd)

    err = pm_runtime_get_sync(dd->dev);
    if (err < 0) {
    + pm_runtime_put_noidle(dd->dev);
    dev_err(dd->dev, "failed to get sync: %d\n", err);
    return err;
    }
    --
    2.27.0
    \
     
     \ /
      Last update: 2020-12-23 03:37    [W:5.058 / U:0.144 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site