lkml.org 
[lkml]   [2020]   [Dec]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.9 37/48] mwifiex: Fix possible buffer overflows in mwifiex_cmd_802_11_ad_hoc_start
    Date
    From: Zhang Xiaohui <ruc_zhangxiaohui@163.com>

    [ Upstream commit 5c455c5ab332773464d02ba17015acdca198f03d ]

    mwifiex_cmd_802_11_ad_hoc_start() calls memcpy() without checking
    the destination size may trigger a buffer overflower,
    which a local user could use to cause denial of service
    or the execution of arbitrary code.
    Fix it by putting the length check before calling memcpy().

    Signed-off-by: Zhang Xiaohui <ruc_zhangxiaohui@163.com>
    Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
    Link: https://lore.kernel.org/r/20201206084801.26479-1-ruc_zhangxiaohui@163.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/wireless/marvell/mwifiex/join.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/net/wireless/marvell/mwifiex/join.c b/drivers/net/wireless/marvell/mwifiex/join.c
    index b89596c18b41a..313b5d9fd08ed 100644
    --- a/drivers/net/wireless/marvell/mwifiex/join.c
    +++ b/drivers/net/wireless/marvell/mwifiex/join.c
    @@ -877,6 +877,8 @@ mwifiex_cmd_802_11_ad_hoc_start(struct mwifiex_private *priv,

    memset(adhoc_start->ssid, 0, IEEE80211_MAX_SSID_LEN);

    + if (req_ssid->ssid_len > IEEE80211_MAX_SSID_LEN)
    + req_ssid->ssid_len = IEEE80211_MAX_SSID_LEN;
    memcpy(adhoc_start->ssid, req_ssid->ssid, req_ssid->ssid_len);

    mwifiex_dbg(adapter, INFO, "info: ADHOC_S_CMD: SSID = %s\n",
    --
    2.27.0
    \
     
     \ /
      Last update: 2020-12-23 03:26    [W:4.596 / U:0.132 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site