Messages in this thread | | | Date | Wed, 23 Dec 2020 03:39:01 +0800 | From | Gao Xiang <> | Subject | Re: [PATCH] erofs: support direct IO for uncompressed file |
| |
Hi Christoph,
On Tue, Dec 22, 2020 at 02:22:34PM +0000, Christoph Hellwig wrote: > Please do not add new callers of __blockdev_direct_IO and use the modern > iomap variant instead.
We've talked about this topic before. The current status is that iomap doesn't support tail-packing inline data yet (Chao once sent out a version), and erofs only cares about read intrastructure for now (So we don't think more about how to deal with tail-packing inline write path). Plus, the original patch was once lack of inline data regression test from gfs2 folks.
The main use case I know so far is to enable direct I/O and leave loop images uncompressed for loop devices. And making the content of the loop images compressed to avoid double caching.
Personally, I'd like to convert it to iomap infrastructure as well. So if it has some concern for __blockdev_direct_IO as an interim solution, hope that Jianan could pick this work up. That would be better.
Thanks, Gao Xiang
>
| |