Messages in this thread | | | Date | Tue, 22 Dec 2020 16:19:00 +0000 | From | Matthew Wilcox <> | Subject | Re: [PATCH 2/3] vfs: Add a super block operation to check for writeback errors |
| |
On Mon, Dec 21, 2020 at 02:50:54PM -0500, Vivek Goyal wrote: > - ret2 = errseq_check_and_advance(&sb->s_wb_err, &f.file->f_sb_err); > + if (sb->s_op->errseq_check_advance) > + ret2 = sb->s_op->errseq_check_advance(sb, f.file);
What a terrible name for an fs operation. You don't seem to be able to distinguish between semantics and implementation. How about check_error()?
| |