lkml.org 
[lkml]   [2020]   [Dec]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v4 12/12] mfd: bd9571mwv: Add support for BD9574MWF
    Hi Shimoda-san,

    On Mon, Dec 21, 2020 at 3:56 AM Yoshihiro Shimoda
    <yoshihiro.shimoda.uh@renesas.com> wrote:
    > From: Khiem Nguyen <khiem.nguyen.xt@renesas.com>
    >
    > The new PMIC BD9574MWF inherits features from BD9571MWV.
    > Add the support of new PMIC to existing bd9571mwv driver.
    >
    > Signed-off-by: Khiem Nguyen <khiem.nguyen.xt@renesas.com>
    > Co-developed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
    > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

    Thanks for your patch!

    > --- a/drivers/mfd/bd9571mwv.c
    > +++ b/drivers/mfd/bd9571mwv.c

    > @@ -200,12 +277,14 @@ static int bd9571mwv_probe(struct i2c_client *client,
    >
    > static const struct of_device_id bd9571mwv_of_match_table[] = {
    > { .compatible = "rohm,bd9571mwv", },
    > + { .compatible = "rohm,bd9574mwf", },
    > { /* sentinel */ }
    > };
    > MODULE_DEVICE_TABLE(of, bd9571mwv_of_match_table);
    >
    > static const struct i2c_device_id bd9571mwv_id_table[] = {
    > - { "bd9571mwv", 0 },
    > + { "bd9571mwv", ROHM_CHIP_TYPE_BD9571 },
    > + { "bd9574mwf", ROHM_CHIP_TYPE_BD9574 },

    Why add the chip types? These are unused, and the driver uses
    autodetection of the chip variant anyway.

    Gr{oetje,eeting}s,

    Geert

    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
    -- Linus Torvalds

    \
     
     \ /
      Last update: 2020-12-22 09:54    [W:2.832 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site