lkml.org 
[lkml]   [2020]   [Dec]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.4 046/130] mmc: tmio: do not print real IOMEM pointer
    Date
    From: Krzysztof Kozlowski <krzk@kernel.org>

    [ Upstream commit ade8e9d3fb9232ddfb87a4bc641b35b988d9757b ]

    Printing kernel pointers is discouraged because they might leak kernel
    memory layout. This fixes smatch warning:

    drivers/mmc/host/tmio_mmc.c:177 tmio_mmc_probe() warn: argument 3 to %08lx specifier is cast from pointer

    Reported-by: kernel test robot <lkp@intel.com>
    Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
    Link: https://lore.kernel.org/r/20201116164252.44078-1-krzk@kernel.org
    Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/mmc/host/tmio_mmc.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/mmc/host/tmio_mmc.c b/drivers/mmc/host/tmio_mmc.c
    index 93e83ad25976e..dedfad7a2fcb1 100644
    --- a/drivers/mmc/host/tmio_mmc.c
    +++ b/drivers/mmc/host/tmio_mmc.c
    @@ -182,8 +182,7 @@ static int tmio_mmc_probe(struct platform_device *pdev)
    if (ret)
    goto host_remove;

    - pr_info("%s at 0x%08lx irq %d\n", mmc_hostname(host->mmc),
    - (unsigned long)host->ctl, irq);
    + pr_info("%s at 0x%p irq %d\n", mmc_hostname(host->mmc), host->ctl, irq);

    return 0;

    --
    2.27.0
    \
     
     \ /
      Last update: 2020-12-23 04:02    [W:2.410 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site